doc(share/p2p/shrexnd): Improve accuracy of RequestND description #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musalbas
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2418 +/- ##
==========================================
+ Coverage 52.96% 52.97% +0.01%
==========================================
Files 156 156
Lines 9915 9915
==========================================
+ Hits 5251 5252 +1
+ Misses 4208 4207 -1
Partials 456 456
|
renaynay
approved these changes
Jul 3, 2023
renaynay
changed the title
vgonkivs
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestNDdoesn't actually verify the inclusion proofs; this is done later inGetSharesByNamespace:https://github.com/celestiaorg/celestia-node/blob/main/share/getters/shrex.go#L237